Code review comment for lp:~michael.nelson/launchpad/3-0-menu

Revision history for this message
Martin Albisetti (beuno) wrote :

> I'm not sure if you are saying that you'd prefer that the formatter didn't
> look up the traversal path (ie. if there is no logo for the
> IDistributionSourcePackage then it should just display the default logo,
> rather than looking to IDistribution first)? If so, then I think the wider
> implications of that change need to be considered (and I'd suggest it isn't
> part of this branch).

No, I think the current behavior is good for now.

> > I see you still haven't moved the breadcrumbs to beneath the title.
>
> No, Julian mentioned the other day that I was only to do the nav, not the
> breadcrumbs. But even if you do want me to do those, I'd still prefer to do
> them as a separate branch - if that's ok?

It is. The breadcrumb issue is something separate from the UI. They need to be more detailed, and I'm going to work on that with Salgado.
If you can handle the UI, while I work out the technical details with Salgado, it would be great.

> This change will affect any page that uses the 3-0 templates (main_only,
> main_side, searchless, locationless.) So, I was wanting to check with Curtis,
> but I was planning on landing this change without updating any other templates
> (it just so happens that Curtis has already landed the searchless template
> changes such as the Distribution search that I used in the examples here and
> that you can see locally). I was under the impression (from Curtis' conversion
> page) that we cannot yet land any changes that update templates to 3-0? (see
> the section "There are some bugs that must be fixed before layouts changes can
> start" at the beginning of the page
> https://dev.launchpad.net/VersionThreeDotO/UI/Conversion)

Sounds good to me.

« Back to merge proposal