Code review comment for lp:~michael.nelson/launchpad/3-0-menu

Revision history for this message
Martin Albisetti (beuno) wrote :

Changes are awesome.

> Note1: I assume 'Launchpad Home' will be disappearing, according to beuno'
> design?

Yes.

> 1. Why is the default heading used in the "heading" metal slot h2? Shouldn't
> it always be h1 (given that the heading in the location is always h2).
>
> Note: I did do a revision where the location_title marked up the title with h1
> or h2 depending on whether the current context itself implemented IHasLogo,
> but that didn't work for pages like:
>
> http://people.canonical.com/~michaeln/menu_3-0/7-ubuntu-search.png
>
> where the context *is* the ubuntu distribution, but we have an h1 heading
> related to search.

I don't think I quite understand this, but if there's only one heading, then it should be h1

review: Approve (ui)

« Back to merge proposal