Code review comment for lp:~michael.nelson/launchpad/3-0-menu

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Michael.

This is a good improvement. I think I have just as may questions as you. I do not think I have any answers. I think Martin needs to give some directions here.

Martin mentioned that the the Overview tab going away. I believe that will
cause havoc here. How do I get from translations to my profile? Do I
click on the icon or pillar title?

If overview is gone, how do we handle the Launchpad Home hack? I do not
think search is Launchpads root page. It is most like a collection such as
people/ and projects/. I guess my concern is about distinguishing the
launchpad application that is being used and our projects. They have the
same icons which confuses me. Is it possible to have a different icon
for the projects and the application?

I wonder what sprint looks like? It is the only non-pillar-person that
has logos. Since a sprint is antonymous from pillars and teams, it probably
should have an icon.

/me can see the PPA is private because the left margin has a stripe.

The default heading is a <h2> because we assume the <h1> is an exception.
The engineer and reviewer need to know when the template must pass a
<h1> to the heading slot because we are looking at the object itself. I
cannot explain this rule. This ws very frustrating for me. I gave up
working on this issue. Let me show you some examples that illustrate
my understanding:

    Distroseries Karmic (has bread crumbs):
        <title> Search packages in Ubuntu Karmic

        {@} Ubuntu Linux
        <h2> Karmic
             Ubuntu > Karmic

        <h1> Search packages in Karmic

    Project edit (no bread crumbs because this is the top):
        <title> Change Bazaar details

        {@} Bazaar Distributed Version Control
        <h2> Bazaar

        <h1> Change details <this is the form label>

    Project (no bread crumbs and pass a <h1>):
        <title> Bazaar Distributed Version Control

        {@} Bazaar Distributed Version Control
        <h1> Bazaar

    Team PPA history
        <title> Launchpad dependencies history

        {@} Canonical Launchpad Developers
        <h2> Launchpad dependencies
             launchpad developers > ppas

        <h1> Launchpad dependencies history

« Back to merge proposal