Code review comment for lp:~michael.nelson/launchpad/3-0-menu

> Hi Michael.
>
> This is a good improvement. I think I have just as may questions as you. I do
> not think I have any answers. I think Martin needs to give some directions
> here.

Thanks for your time Curtis! Just to aid our call, here are some thoughts.

>
> Martin mentioned that the the Overview tab going away. I believe that will
> cause havoc here. How do I get from translations to my profile? Do I
> click on the icon or pillar title?

Yes, I have not done any removing - I was just noting that that's why my screenshot didn't look exactly like his mockup.

>
> If overview is gone, how do we handle the Launchpad Home hack? I do not
> think search is Launchpads root page. It is most like a collection such as
> people/ and projects/.

OK, I'm not sure I understand this point. Looking at:

http://people.canonical.com/~michaeln/menu_3-0/6-no-location-default-launchpad.png

which I assume would (currently in the branch) also apply to collections, could we not make the icon itself the link to Launchpad? (and if we wanted, also in other contexts, to the project/person etc.)

> I guess my concern is about distinguishing the
> launchpad application that is being used and our projects. They have the
> same icons which confuses me. Is it possible to have a different icon
> for the projects and the application?

Ah, I see the confusion. So it is really just an isolated case for the Launchpad project right? Hmm.. or maybe I've misunderstood?

>
> I wonder what sprint looks like? It is the only non-pillar-person that
> has logos. Since a sprint is antonymous from pillars and teams, it probably
> should have an icon.
>

Currently it would look something like this:
http://people.canonical.com/~michaeln/menu_3-0/11-sprint.png

> /me can see the PPA is private because the left margin has a stripe.
>
>
> The default heading is a <h2> because we assume the <h1> is an exception.
> The engineer and reviewer need to know when the template must pass a
> <h1> to the heading slot because we are looking at the object itself. I
> cannot explain this rule. This ws very frustrating for me. I gave up
> working on this issue. Let me show you some examples that illustrate
> my understanding:
>
> Distroseries Karmic (has bread crumbs):
> <title> Search packages in Ubuntu Karmic
>
> {@} Ubuntu Linux
> <h2> Karmic
> Ubuntu > Karmic
>
> <h1> Search packages in Karmic
>

OK, I don't think this one is an issue - it seems more like the heading just needs updating like this:

http://people.canonical.com/~michaeln/menu_3-0/8-distroseries-search-change.png

And to highlight why I thought the heading slot should default to h1, here's the example where we *would* use the default heading:

http://people.canonical.com/~michaeln/menu_3-0/9-distroseries-index.png

>
> Project edit (no bread crumbs because this is the top):
> <title> Change Bazaar details
>
> {@} Bazaar Distributed Version Control
> <h2> Bazaar
>
> <h1> Change details <this is the form label>

Similar to the distroseries search above, I'm not sure why the template wouldn't just override the heading slot with <h1> Change details for the project 'Bazaar'</h1> (with whatever formatting you want).

That is, the {@} <h2>Bazaar Distributed Version Control</h2> is already there, so I don't see the need for the extra h2 heading.

>
>
> Project (no bread crumbs and pass a <h1>):
> <title> Bazaar Distributed Version Control
>
> {@} Bazaar Distributed Version Control
> <h1> Bazaar
>

So here there is a small issue, in that I think the h1 heading will or should replicate the {@} <h2> Bazaar Distributed Version Control </h2>.

Like this:

http://people.canonical.com/~michaeln/menu_3-0/10-project-index.png

The other option that I tried, was, in this situation, using an h1 for the {@} <h1>Bazaar...., but there were a number of problems with it.

>
> Team PPA history
> <title> Launchpad dependencies history
>
> {@} Canonical Launchpad Developers
> <h2> Launchpad dependencies
> launchpad developers > ppas
>
> <h1> Launchpad dependencies history

And here I would have thought the template would override the heading slot with <h1>Launchpad dependencies history</h1>, which would again alleviate the problem?

Thanks again for helping me understand the issues!