Code review comment for lp:~michael.nelson/launchpad/409187-trivial-ui-fixes-for-p3a-access

Revision history for this message
Barry Warsaw (barry) wrote :

Looks very good, and the movie really helped! The only thing that's weird for me is leaving the date blank to mean never expire. There's no need to hold up the branch for this, so I'll just ramble a bit.

If possible, the date picker maybe should have a "Never expire" button. You'd use this both in the initial date choice but also if you then decide to extend a user's access to "forever". Also, if access never expires, it would be nice if the date field actually said that, instead of being blank.

With these changes, you'd be able to get rid of the helpful text explaining what a blank field means.

If you think these are worthwhile changes to make, file a bug and fix it later. But the ui as it is looks otherwise great.

review: Approve (ui*)

« Back to merge proposal