Code review comment for lp:~michael.nelson/launchpad/429353-site-message-to-footer

Revision history for this message
Brad Crittenden (bac) wrote :

Michael,

The new changes you made look good with the addition of the small change we discussed on IRC:

=== modified file 'lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt'
--- lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt 2009-08-30 13:31:02 +0000
+++ lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt 2009-09-16 15:38:49 +0000
@@ -53,7 +53,8 @@

+In addition to this prominent display on the root page, each page will
+also include the disable-redirect link in the site_message - if the
+user is a member of the beta group and has not already disabled
+the redirects.

s/each page will/most pages will/

review: Approve (code)

« Back to merge proposal