Code review comment for lp:~michael.nelson/launchpad/443353-api-builds-from-private

Overview
========

This branch fixes bug 443353 by ensuring that getBuildsForSources() will include builds that were originally built in a different archive context, but have since had binaries copied into the source archive context.

Issues
======

There are two main issues with this branch IMO.

1. Ensuring that the result of the union was ordered correctly is hackish, and dependent on a storm implementation detail (that columns in SQL queries for a certain table are ordered alphabetically).

2. Testing the correct ordering in the doctest isn't so readable. It could be better to print out the results instead, but on the other hand, I didn't want the test to be dependent on database ids. Previously the test simply ensured the last item was the one expected - I've updated this to instead assure that the complete result is sorted as expected.

Any suggestions welcome!

Testing/QA
==========

To test, run:
bin/test -vvt doc/publishing.txt

To QA:

Visit:
https://edge.launchpad.net/ubuntu/+source/openjdk-6

and expand the intrepid 6b12-0ubuntu6.6 security release. Currently this only displays two builds, where as it should display all the builds listed at:

https://edge.launchpad.net/ubuntu/+source/openjdk-6/6b12-0ubuntu6.6