Code review comment for lp:~michael.nelson/launchpad/450124-findBuildCandidate_improvements

Revision history for this message
Michael Nelson (michael.nelson) wrote :

= Summary =

Ensures that private PPAs are able to have builds for the same
architecture building in parallel.

== Pre-implementation notes ==

Chatted with Julian about other options - see bug 450124 for
documentation of those discussions.

== Implementation details ==

I had to create a unittest as the documentation is getting unreadable. I
also reverted the additional specific test that I had added to the
documentation now that it is covered by the unittest.

== Tests ==

bin/test -vvt TestFindBuildCandidate

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/model/builder.py
  lib/lp/testing/factory.py
  lib/lp/soyuz/doc/buildd-dispatching.txt
  lib/lp/soyuz/tests/test_builder.py
  lib/lp/soyuz/interfaces/builder.py

--
Michael

« Back to merge proposal