Code review comment for lp:~michael.nelson/launchpad/475808-unembargoing-oops

= Summary =

We need to check which component a delayed copy *will* be overridden to, when accepting it, rather than relying on the spr.component. This is a fix for bug 475808.

== Proposed fix ==

This branch ensures that when the component of a delayed_copy is checked before accepting it, the ancestry component is taken into account (as we can't actually do the component override until we publish the source package publishing history).

== Pre-implementation notes ==

See the pre-imp notes on bug 475808

== Implementation details ==

== Tests ==

bin/test -vvt DoDelayedCopyTestCase

== Demo and Q/A ==

We will need to Q/A this on dogfood.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/model/queue.py
  lib/lp/soyuz/scripts/tests/test_copypackage.py

== Pylint notices ==

lib/lp/soyuz/model/queue.py
    21: [F0401] Unable to import 'email.MIMEMultipart' (No module named MIMEMultipart)
    22: [F0401] Unable to import 'email.MIMEText' (No module named MIMEText)

--
Michael