1
=== modified file 'lib/lp/soyuz/stories/soyuz/xx-distroarchseries-binpackages.txt'
2
--- lib/lp/soyuz/stories/soyuz/xx-distroarchseries-binpackages.txt	2009-11-09 17:08:21 +0000
3
+++ lib/lp/soyuz/stories/soyuz/xx-distroarchseries-binpackages.txt	2009-12-11 15:34:16 +0000
4
@@ -109,6 +109,46 @@
5
109
    >>> print dfiles_element.find(name='a')['href']
109
    >>> print dfiles_element.find(name='a')['href']
6
110
    http://localhost:58000/40/mozilla-firefox_0.9_i386.deb
110
    http://localhost:58000/40/mozilla-firefox_0.9_i386.deb
7
111
111
8
112
If the binary package did produce files, but those files have been
9
113
subsequently deleted, this will also be indicated and the file will
10
114
not be linked.
11
115
12
116
    First we need to get a handle on the right binary file.
13
117
    >>> login('admin@canonical.com')
14
118
    >>> from zope.component import getUtility
15
119
    >>> from lp.registry.interfaces.distribution import IDistributionSet
16
120
    >>> warty = getUtility(IDistributionSet)['ubuntu']['warty']
17
121
    >>> firefox_build = warty.getBuildRecords(
18
122
    ...     name='mozilla-firefox', arch_tag='i386')[0]
19
123
    >>> firefox_deb = firefox_build.binarypackages[0].files[0]
20
124
    >>> print firefox_deb.libraryfile.filename
21
125
    mozilla-firefox_0.9_i386.deb
22
126
23
127
    Next we manually ensure that the file is deleted.
24
128
    >>> firefox_deb.libraryfile.deleted
25
129
    False
26
130
    >>> from zope.security.proxy import removeSecurityProxy
27
131
    >>> removeSecurityProxy(firefox_deb.libraryfile).content = None
28
132
    >>> firefox_deb.libraryfile.deleted
29
133
    True
30
134
    >>> import transaction
31
135
    >>> transaction.commit()
32
136
    >>> logout()
33
137
34
138
    Now reload the page to see the deleted file without the link.
35
139
36
140
    >>> browser.reload()
37
141
    >>> files_element = find_tag_by_id(browser.contents, 'files')
38
142
    >>> print extract_text(files_element)
39
143
    i386 build of mozilla-firefox 0.9 in ubuntu warty RELEASE
40
144
    produced these files:
41
145
    mozilla-firefox_0.9_i386.deb (deleted)
42
146
43
147
    >>> dfiles_element = find_tag_by_id(
44
148
    ...     browser.contents, 'downloadable-files')
45
149
    >>> print dfiles_element.find(name='a')
46
150
    None
47
151
48
112
Binary Packages with no files to present results in a clear statement
152
Binary Packages with no files to present results in a clear statement
49
113
intead of a empty section.
153
intead of a empty section.
50
114
154
51
@@ -118,7 +158,6 @@
52
118
    i386 build of pmount 0.1-1 in ubuntu hoary RELEASE
158
    i386 build of pmount 0.1-1 in ubuntu hoary RELEASE
53
119
    produced no files for this binary package.
159
    produced no files for this binary package.
54
120
160
55
121
56
122
== DistroArchSeries Partner Binary Package Pages ==
161
== DistroArchSeries Partner Binary Package Pages ==
57
123
162
58
124
Binary partner packages in Launchpad differ from regular packages by
163
Binary partner packages in Launchpad differ from regular packages by
59
125
164
60
=== modified file 'lib/lp/soyuz/templates/distroarchseriesbinarypackagerelease-index.pt'
61
--- lib/lp/soyuz/templates/distroarchseriesbinarypackagerelease-index.pt	2009-09-15 16:44:17 +0000
62
+++ lib/lp/soyuz/templates/distroarchseriesbinarypackagerelease-index.pt	2009-12-11 15:34:16 +0000
63
@@ -46,10 +46,16 @@
64
46
        <div id="downloadable-files">
46
        <div id="downloadable-files">
65
47
            <ul tal:condition="context/files">
47
            <ul tal:condition="context/files">
66
48
              <li tal:repeat="file context/files">
48
              <li tal:repeat="file context/files">
71
49
                <a class="sprite"
49
                <tal:deleted condition="file/libraryfile/deleted">
72
50
                   tal:content="file/libraryfile/filename"
50
                  <tal:filename content="file/libraryfile/filename" />
73
51
                   tal:attributes="href file/libraryfile/http_url"></a>
51
                  (deleted)
74
52
                (<span tal:replace="file/libraryfile/content/filesize/fmt:bytes" />)
52
                </tal:deleted>
75
53
                <tal:not-deleted condition="not: file/libraryfile/deleted">
76
54
                  <a class="sprite"
77
55
                     tal:content="file/libraryfile/filename"
78
56
                     tal:attributes="href file/libraryfile/http_url"></a>
79
57
                  (<span tal:replace="file/libraryfile/content/filesize/fmt:bytes" />)
80
58
                </tal:not-deleted>
81
53
              </li>
59
              </li>
82
54
            </ul>
60
            </ul>
83
55
        </div>
61
        </div>
Reviewer	Review Type	Date Requested	Status
Abel Deuring (community)	code	2009-12-11	Approve on 2009-12-11
Review via email: mp+16026@code.launchpad.net