Code review comment for lp:~michael.nelson/launchpad/499095-build-retry-depwait-stuck

= Summary =
This is a fix for the 2nd cause of bug 499095, where we sometimes get builds on builders with inconsistent states (date_started is not set because the job was already in the RUNNING state).

For details of the cause, see the comments:
https://bugs.edge.launchpad.net/soyuz/+bug/499095/comments/4
https://bugs.edge.launchpad.net/soyuz/+bug/499095/comments/11

== Proposed fix ==

Ensure that the job status is correctly reset back to WAITING after buildStatus_GIVENBACK() and buildStatus_BUILDERFAIL().

== Pre-implementation notes ==

Worked with wgrant to diagnose and fix this second cause.

We really need to update the bm logs so we can see the relevant info. Much of the bm logging is done as warning/debug which doesn't seem to be logged currently.

== Implementation details ==

Nothing weird.

== Tests ==

bin/test -vvt buildd-slavescanner.txt

== Demo and Q/A ==

We can QA this on dogfood (wgrant already QA'd the core of the fix locally).

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/buildmaster/buildergroup.py
  lib/lp/soyuz/doc/buildd-slavescanner.txt