Launchpad itself

Code review comment for lp:~michael.nelson/launchpad/510331-syncsources-latest-pub

  1. 510331-syncsources-latest-pub
  2. Merge into devel
Revision history for this message
Michael Nelson (michael.nelson) wrote :

<noodles775> gmb, jtv: http://pastebin.ubuntu.com/367524/
<noodles775> Looks like is_empty isn't included on the ISQLObjectResultSet in storm.zope.interfaces :/
<gmb> ?!
<gmb> Oh, ah.
<gmb> I see.
<gmb> That's suboptimal.
<gmb> noodles775: In that case, just go back to using .count(). You could maybe file a tech-debt bug about changing getPublishedSources() to use Storm, but I don't know how worthwhile that would be.
<noodles775> Yep, thanks.

« Back to merge proposal