Code review comment for lp:~michael.nelson/launchpad/588288-log-parser-dont-read-entire-file-qa

Thanks Abel. Regarding the exception handling, it looks to me as if that is by design (but I didn't design it ;)) - that is, if there is an error the log parser will not continue past the line where the error occurred until it has been resolved (so that we don't end up skipping chunks of the file, but are rather alerted to it). I'm basing this on the test:

    def test_unexpected_error_while_parsing(self):
        # When there's an unexpected error, we log it and return as if we had
        # parsed up to the line before the one where the failure occurred.

I can create a bug with your comments for the foundations guys to look at if you think it's worthwhile.
Thanks!