On Fri, Jun 4, 2010 at 6:22 PM, Abel Deuring <email address hidden> wrote:
> Review: Approve code
> Nice work! Just one nitpick:
>
> === modified file 'lib/lp/buildmaster/model/builder.py'
> --- lib/lp/buildmaster/model/builder.py 2010-05-18 08:54:36 +0000
> +++ lib/lp/buildmaster/model/builder.py 2010-06-04 15:28:29 +0000
>
> + BinaryPackageBuild.distro_arch_series == DistroArchSeries.id,
> DistroArchSeries.processorfamilyID == Processor.familyID,
> + # WHERE
>
> This "WHERE" looks a bit odd ;) I think you can remove it.
Done...(woops, left over from the SQL->Storm conversion). Thanks Abel.
On Fri, Jun 4, 2010 at 6:22 PM, Abel Deuring <email address hidden> wrote: buildmaster/ model/builder. py' buildmaster/ model/builder. py 2010-05-18 08:54:36 +0000 buildmaster/ model/builder. py 2010-06-04 15:28:29 +0000
> Review: Approve code
> Nice work! Just one nitpick:
>
> === modified file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
>
> + BinaryPackageBu ild.distro_ arch_series == DistroArchSerie s.id, s.processorfami lyID == Processor.familyID,
> DistroArchSerie
> + # WHERE
>
> This "WHERE" looks a bit odd ;) I think you can remove it.
Done...(woops, left over from the SQL->Storm conversion). Thanks Abel.