Code review comment for lp:~michael.nelson/launchpad/649559-ajax-comment-on-dsdiff-2

Revision history for this message
Henning Eggers (henninge) wrote :

This looks really great! Thank you!

As discussed on IRC, though, I am really worried about the reverse ordering of the comments. Not that I don't like it, it is just inconsistent with other commenting we have in LP (bugs, mps, questions). You mentioned that you considered it more like a "wall" where people post notices. I see three possible solutions:

 1. You simply adopt forward ordering for these comments and new comments are written at the bottom. I think it would be ok to only see latest 5 comments or so.

 2. We consider adopting the reverse-ordered "wall" concept for all our commenting on Launchpad. That would have to be discussed on the mailing list but you already declined it yourself for MPs.

 3. We make the "wall" concept visually different from the "comment" concept, so people are aware that they work differently. This should be more than just a different headline (although that would work as a temporary solution) and might take us back to your original design of the comments (I am sorry, I did not notice the reverse ordering then).

That said, I can only repeat that the page looks great and I just love to hear your voice! ;-)

Henning

review: Needs Fixing (ui*)

« Back to merge proposal