Launchpad itself

Code review comment for lp:~michael.nelson/launchpad/649559-ajax-comment-on-dsdiff-2

649559-ajax-comment-on-dsdiff-2
Merge into db-devel

Revision history for this message

Michael Nelson (michael.nelson) wrote on 2010-09-30:

IRC conversation with Henning and James:

12:15 < noodles775> Hi henninge, can I interest you in another UI review? http://people.canonical.com/~michaeln/tmp/649559-blacklisting-with-comments.ogv
12:15 < noodles775> Actual MP here: https://code.edge.launchpad.net/~michael.nelson/launchpad/649559-ajax-comment-on-dsdiff-2/+merge/37114
12:16 < henninge> noodles775: sure, but I have to finish something first.
12:17 * henninge watches screencast right away, though ... ;)
12:17 < noodles775> henninge: no problem (or if you're busy, salgado will be around a bit later too). Thanks.
12:17 < noodles775> Ah :)
12:18 < henninge> noodles775: hm, aren't comments always sorted from oldest to newest in LP? We should stick to that.
12:20 < noodles775> henninge: I wasn't sure in this case - it is more like a wall... as a user, the information I want is the most recent comments. But it's easy to switch.
12:20 < henninge> noodles775: also, in the same vein, "Add comment" is usually placed at the end of the list of comments.
12:20 < henninge> noodles775: Did I mention that this looks great! ;-D
12:21 < henninge> noodles775: sorry for starting off with the negative things ... ;)
12:21 < noodles775> henninge: yes, if the comments are going oldest to newest, then of course it would be at the end. It's only there because I did it more like a wall.
12:21 < noodles775> No problem! Thanks for the feedback.
12:21 < henninge> noodles775: well, I don't see how this case is different from other commenting we have in LP
12:22 < noodles775> henninge: The biggest difference, IMO, is that we're displaying lists of comments for multiple objects on the one page. Ideally, if I had more time, we'd only be showing the 5 latest comments for each (in the details section).
12:22 < henninge> noodles775: mp's have a "Add a review or comment" button on top of the comments that scrolls you down to the end.
12:22 < henninge> dunno why bugs don't.
12:24 < henninge> noodles775: I am not opposed to introducing a "wall" concept for short comments - but they should look different to mark the difference in behaviour.
12:24 < noodles775> james_w: if you're around and have a minute, would you also prefer standard oldest to newest comments for the differences (see above screencast). I've currently got them with the newest first, assuming that's the info that will be needed, but it's easy to switch back.
12:26 < noodles775> henninge: If the heading was "Most recent comments" instead of "Comments" (and later we added a link to the full details for a particular difference with all comments) would that help differentiate?
12:26 < noodles775> (er, and we only showed the 5 most recent on this page?)
12:28 < henninge> noodles775: That would probably help but I still think people will get confused about the ordering.
12:29 < henninge> noodles775: I actually think the reverse ordering is preferrable
12:29 < noodles775> henninge: yeah, perhaps. Let's see what james_w or other people who will be using this say. I'm happy to change it - it's an easy switch.
12:30 < henninge> noodles775: I don't know if it has been discussed before but maybe you could post your screencast to the list and start a discussion to adopt this for all our comments?
12:30 < henninge> but maybe that is not always wanted ...
12:31 < henninge> hm
12:34 < noodles775> henninge: no, I think a merge proposal is a story... it should be ordered from oldest to newest.
12:35 < noodles775> The few comments that will ever be used for these differences are things like "Waiting for version 2.5".
12:41 < henninge> noodles775: I put that all in a review comment. Not approved until we decide on a way to go with this.
12:41 < henninge> noodles775: but thanks a lot for the great work! ;-)
12:41 < noodles775> henninge: yep, that's great (and I don't mind which way... just what works for the people using it). Thanks!

14:44 < james_w> noodles775: I think newest first makes some sense here, but I don't know if consistency should win out
14:46 < noodles775> OK, thanks james_w - let's see what the ui reviewers (henninge and sinzui) decide.

IRC conversation with Henning and James:

12:15 < noodles775> Hi henninge, can I interest you in another UI review? http://people.canonical.com/~michaeln/tmp/649559-blacklisting-with-comments.ogv
12:15 < noodles775> Actual MP here: https://code.edge.launchpad.net/~michael.nelson/launchpad/649559-ajax-comment-on-dsdiff-2/+merge/37114
12:16 < henninge> noodles775: sure, but I have to finish something first.
12:17  * henninge watches screencast right away, though ... ;)
12:17 < noodles775> henninge: no problem (or if you're busy, salgado will be around a bit later too). Thanks.
12:17 < noodles775> Ah :)
12:18 < henninge> noodles775: hm, aren't comments always sorted from oldest to newest in LP? We should stick to that.
12:20 < noodles775> henninge: I wasn't sure in this case - it is more like a wall... as a user, the information I want is the most recent comments. But it's easy to switch.
12:20 < henninge> noodles775: also, in the same vein, "Add comment" is usually placed at the end of the list of comments.
12:20 < henninge> noodles775: Did I mention that this looks great! ;-D
12:21 < henninge> noodles775: sorry for starting off with the negative things ... ;)
12:21 < noodles775> henninge: yes, if the comments are going oldest to newest, then of course it would be at the end. It's only there because I did it more like a wall.
12:21 < noodles775> No problem! Thanks for the feedback.
12:21 < henninge> noodles775: well, I don't see how this case is different from other commenting we have in LP
12:22 < noodles775> henninge: The biggest difference, IMO, is that we're displaying lists of comments for multiple objects on the one page. Ideally, if I had more time, we'd only be showing the 5 latest comments for each (in the details section).
12:22 < henninge> noodles775: mp's have a "Add a review or comment" button on top of the comments that scrolls you down to the end.
12:22 < henninge> dunno why bugs don't.
12:24 < henninge> noodles775: I am not opposed to introducing a "wall" concept for short comments - but they should look different to mark the difference in behaviour.
12:24 < noodles775> james_w: if you're around and have a minute, would you also prefer standard oldest to newest comments for the differences (see above screencast). I've currently got them with the newest first, assuming that's the info that will be needed, but it's easy to switch back.
12:26 < noodles775> henninge: If the heading was "Most recent comments" instead of "Comments" (and later we added a link to the full details for a particular difference with all comments) would that help differentiate?
12:26 < noodles775> (er, and we only showed the 5 most recent on this page?)
12:28 < henninge> noodles775: That would probably help but I still think people will get confused about the ordering.
12:29 < henninge> noodles775: I actually think the reverse ordering is preferrable
12:29 < noodles775> henninge: yeah, perhaps. Let's see what james_w or other people who will be using this say. I'm happy to change it - it's an easy switch.
12:30 < henninge> noodles775: I don't know if it has been discussed before but maybe you could post your screencast to the list and start a discussion to adopt this for all our comments?
12:30 < henninge> but maybe that is not always wanted ...
12:31 < henninge> hm
12:34 < noodles775> henninge: no, I think a merge proposal is a story... it should be ordered from oldest to newest.
12:35 < noodles775> The few comments that will ever be used for these differences are things like "Waiting for version 2.5".
12:41 < henninge> noodles775: I put that all in a review comment. Not approved until we decide on a way to go with this.
12:41 < henninge> noodles775: but thanks a lot for the great work! ;-)
12:41 < noodles775> henninge: yep, that's great (and I don't mind which way... just what works for the people using it). Thanks!

« Back to merge proposal