Code review comment for lp:~michael.nelson/launchpad/649559-ajax-comment-on-dsdiff-2

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Michael,

a nice branch. I agree that importing a model class to browser just in order to get a parameter for order_by() is a bit odd, but I think it won't hurt much.

Just one stylistic nitpick: The phrase "This method is responsible for adding..." appears at least in two doc strings; I would prefer a simple "This method adds..."

review: Approve (code)

« Back to merge proposal