Code review comment for lp:~michael.nelson/launchpad/delegate-to-buildfarmjob

Revision history for this message
Brad Crittenden (bac) wrote :

Hi Michael,

This branch looks good.

Since _set_build_farm_job() is a method which is intended to be overridden please provide a docstring for it.

Also, our coding guidelines state the docstring must be a single line followed by a longer explanation if needed. It is quite Draconian and leads to some haiku-like challenges but please see if you can adhere to the rule.

review: Approve (code)

« Back to merge proposal