Code review comment for lp:~michael.nelson/launchpad/distro-series-difference-browser2

Revision history for this message
Leonard Richardson (leonardr) wrote :

It's been a while since I did anything with TALES, but I think I was able to follow this. I approve with only minor comments:

line 48 "betteen"
Can 58 and 59 fit on one line?
Why are lines 134 and 135 commented out? It seems like an important part of the test.
Is it really OK to have the python: call on line 328? I remember that being discouraged.

review: Approve

« Back to merge proposal