Code review comment for lp:~michael.nelson/launchpad/distro-series-difference-browser2

Am 08.09.2010 11:19, schrieb Michael Nelson:
> http://launchpadlibrarian.net/55200786/627295-ui-tweaks.png

That looks very nice, thank you! I like your solution for the comment column.

>
>> - I am not sure an extra column for the package name would really look bad
>
> I've switched it back and added an extra Source column

Yes, that is a bit clearer to read.

You have not yet explained why the version numbers in hoary are lower than in
the parent series warty. Is that just bad sample data or am I reading the
table wrong?

>> About the mockup (for further consideration):
>> - It would be really cool if the "Add to blacklist" button was some new control that is a combination of a button and a drop down menu. Opening an extra dialog here seems too distracting to me.
>
> Yes - to me also - it was my main concern with that reworking. I
> chatted with Julian about this and we thought it makes sense to simply
> provide two buttons "Blacklist Foo", or "Blacklist Foo 1.34-a"
>
> What do you think?

Two buttons would not be my favorite solution because a lot of text might end
up on them. "Blacklist this version" and "Blacklist all versions" makes two
huge buttons next to each other that eat a lot of horizontal space. Putting
them on top of each other would be the obvious answer but that might look odd,
too.
I wonder if a status picker could be used instead although that is closer to
the extra dialog we were trying to avoid in the first place.

> Thanks for the thoughtful review!

I enjoyed it! ;-)

Henning