Code review comment for lp:~michael.nelson/launchpad/distro-series-difference-browser2

On Tue, Sep 7, 2010 at 7:44 PM, Curtis Hovey <email address hidden> wrote:
> Review: Approve ui
> This looks really nice. I love this page because it can answer questions I have about the how any distroseries diverges from its parent. I think Henning's review is excellent and I really applaud the work everyone has done on this. I have a few questions about what I cannot see from data and mockups, that may be of concern in the near future.

Thanks for the feedback Curtis!

>
> How will this handle non-intersections, or packages marked as deleted? eg.
>    https://edge.launchpad.net/ubuntu/maverick/+source/beagle
> Will I see "Deleted" or "Not present"?

If a package is not published in the parent series (because it has
been deleted), but is present in the derived series, then it will be a
different type of difference (UNIQUE_TO_DERIVED) and displayed on a
separate page. This page only displays packages that are present in
both series. (Or did I misunderstand your question?)

>
> Where is that package description coming from? These look like source packages, not binaries. I recently added a summary field to DSPs and SPs that is built from binary summaries--it does not look like the descriptions in the mockup.

Indeed - I think it can only use the new summary attribute that you've
added. Thanks!

> --
> https://code.launchpad.net/~michael.nelson/launchpad/distro-series-difference-browser2/+merge/34739
> You are the owner of lp:~michael.nelson/launchpad/distro-series-difference-browser2.
>