Code review comment for lp:~michael.nelson/launchpad/ppa-privatisation-test-refactor4

This is the fourth branch in a series to refactor soyuz tests after fixing bug 506203.

The MP for the branch that actually fixed the bug is at:

https://code.edge.launchpad.net/~michael.nelson/launchpad/506203-ppa-privatisation-check/+merge/19415

The fix ensures that the privacy of a PPA cannot be altered once it has packages published. Unfortunately most of our test infrastructure does exactly that (switches the privacy to do a few tests and then switches it back).

The complete test breakages are as follows:
http://pastebin.ubuntu.com/378292/

This branch fixes:

bin/test -vv -t archiveauthtoken.txt -t archivesubscriber.txt -t doc/build.txt -t package-diff.txt -t sourcepackagerelease.txt -t xx-ppa-files.txt

Thanks.