Thanks for working on this branch. I'm psyched to see us nailing down these
blueprint pages as we finish up 3.0.
As mentioned in irc, sprint-index doesn't look quite right because of the
breadcrumbs that shouldn't be there. I have a hack, er, solution for that
attached below. It basically puts a null +hierarchy view on the page. We
might want to consider generalizing that or providing an easier way to do it.
If you want to open a bug asking for that, I might be able to fix it
post-3.0. For now, this hack will work.
First, let's look at the code. I'll omit the stuff that looks fine.
Is it possible to just print the text and use ellipses to omit anything you
don't care about? That would be better for documentation/testing purposes
than just printing True.
Here's a diff that will fix the breadcrumbs. It might need a little cleaning
up, but should give you the idea.
With consideration of these comments, merge-conditional, r=me.
Hi Michael,
Thanks for working on this branch. I'm psyched to see us nailing down these
blueprint pages as we finish up 3.0.
As mentioned in irc, sprint-index doesn't look quite right because of the
breadcrumbs that shouldn't be there. I have a hack, er, solution for that
attached below. It basically puts a null +hierarchy view on the page. We
might want to consider generalizing that or providing an easier way to do it.
If you want to open a bug asking for that, I might be able to fix it
post-3.0. For now, this hack will work.
First, let's look at the code. I'll omit the stuff that looks fine.
=== modified file 'lib/lp/ blueprints/ browser/ sprint. py' blueprints/ browser/ sprint. py 2009-09-16 18:18:49 +0000 blueprints/ browser/ sprint. py 2009-09-18 10:49:12 +0000 enu(Application Menu): enu(NavigationM enu):
--- lib/lp/
+++ lib/lp/
> @@ -69,7 +70,7 @@
> usedfor = ISprint
>
>
> -class SprintOverviewM
> +class SprintOverviewM
While you're here can you give this class a docstring?
=== modified file 'lib/lp/ blueprints/ stories/ sprints/ 05-sprint- creation. txt' blueprints/ stories/ sprints/ 05-sprint- creation. txt 2009-09-15 10:26:04 +0000 blueprints/ stories/ sprints/ 05-sprint- creation. txt 2009-09-18 11:31:27 +0000 user_browser. contents, 'Meeting details') text(find_ tag_by_ id(user_ browser. contents, 'start-end'))
--- lib/lp/
+++ lib/lp/
> @@ -80,14 +80,9 @@
> Since the sprint's time zone was set to UTC, the dates are displayed in
> that time zone:
>
> - >>> print find_portlet(
> - <...
> - ...Starts:...
> - 2006-10-10 09:15 UTC...
> - ...Ends:...
> - 2006-10-13 16:00 UTC...
> - ...
> -
> + >>> print extract_
> + Starts: 09:15 UTC on Tuesday, 2006-10-10
> + Ends: 16:00 UTC on Friday, 2006-10-13
Thanks for cleaning these up!
=== modified file 'lib/lp/ blueprints/ stories/ sprints/ 10-sprint- editing. txt' blueprints/ stories/ sprints/ 10-sprint- editing. txt 2009-09-16 17:32:51 +0000 blueprints/ stories/ sprints/ 10-sprint- editing. txt 2009-09-18 10:49:12 +0000 launchpad. dev/sprints/ ubz')
--- lib/lp/
+++ lib/lp/
> @@ -2,8 +2,8 @@
> available to those who have permissions to edit that sprint.
>
> >>> anon_browser.open('http://
> - >>> anon_browser.title
> - 'Ubuntu Below Zero (sprint or meeting)'
> + >>> print anon_browser.title
> + Ubuntu Below Zero : Meetings
And these. If you have the inclination, can you indent the interactive
prompts 4 spaces?
=== modified file 'lib/lp/ blueprints/ stories/ sprints/ sprint- settopics. txt' blueprints/ stories/ sprints/ sprint- settopics. txt 2009-08-13 19:03:36 +0000 blueprints/ stories/ sprints/ sprint- settopics. txt 2009-09-18 10:49:12 +0000 launchpad. dev/sprints/ uds-guacamole' browser. contents, 'Meeting details') text(meeting_ portlet. find(text= 'Driver: ').findNext( 'a')) by_id(browser. contents, 'meeting-drivers') text(meeting_ drivers. findNext( 'a'))
--- lib/lp/
+++ lib/lp/
> @@ -55,8 +55,8 @@
> 'http://
>
> >>> ut = 'Ubuntu Team'
> - >>> meeting_portlet = find_portlet(
> - >>> ut in extract_
> + >>> meeting_drivers = find_tag_
> + >>> ut in extract_
> True
Is it possible to just print the text and use ellipses to omit anything you testing purposes
don't care about? That would be better for documentation/
than just printing True.
Here's a diff that will fix the breadcrumbs. It might need a little cleaning
up, but should give you the idea.
With consideration of these comments, merge-conditional, r=me.
=== modified file 'lib/lp/ blueprints/ browser/ configure. zcml' blueprints/ browser/ configure. zcml 2009-09-17 21:20:14 +0000 blueprints/ browser/ configure. zcml 2009-09-18 15:54:43 +0000
for=" lp.blueprints. interfaces. sprint. ISprint"
path_ expression= "name"
parent_ utility= "lp.blueprints. interfaces. sprint. ISprintSet" /> blueprints. interfaces. sprint. ISprint" lp.blueprints. browser. sprint. SprintIndexHier archy" "../../ app/templates/ launchpad- hierarchy. pt" "zope.Public"
for=" lp.blueprints. interfaces. sprint. ISprint"
class= "lp.blueprints. browser. sprint. SprintView"
--- lib/lp/
+++ lib/lp/
@@ -23,6 +23,13 @@
+ <browser:page
+ for="lp.
+ name="+hierarchy"
+ class="
+ template=
+ permission=
+ />
<browser:pages
=== modified file 'lib/lp/ blueprints/ browser/ sprint. py' blueprints/ browser/ sprint. py 2009-09-18 10:49:12 +0000 blueprints/ browser/ sprint. py 2009-09-18 15:56:04 +0000 ndingView' , tView', ets', rarchy' , tingExportView' , igation' , rviewMenu' , ormView, LaunchpadView, Link, Navigation, NavigationMenu, unchpadFacets, action, canonical_url, custom_widget, with_permission ) launchpad. browser. launchpad import Hierarchy launchpad. webapp. batching import BatchNavigator launchpad. webapp. breadcrumb import Breadcrumb launchpad. helpers import shortlist
--- lib/lp/
+++ lib/lp/
@@ -10,6 +10,7 @@
'SprintBra
'SprintEdi
'SprintFac
+ 'SprintIndexHie
'SprintMee
'SprintNav
'SprintOve
@@ -47,6 +48,7 @@
LaunchpadF
StandardLa
enabled_
+from canonical.
from canonical.
from canonical.
from canonical.
@@ -151,12 +153,20 @@
enable_only = ['overview', ]
+class SprintIndexHier archy(Hierarchy ): breadcrumbs( self): HasSpecificatio nsView, LaunchpadView):
+ @property
+ def display_
+ return False
+
+
class SprintView(
__used_for__ = ISprint
implements (IMajorHeadingV iew)
+ label = 'Meeting overview'
self. notices = []
self. latest_ specs_limit = 5
+
def initialize(self):
=== modified file 'lib/lp/ blueprints/ templates/ sprint- index.pt' blueprints/ templates/ sprint- index.pt 2009-09-18 10:49:12 +0000 blueprints/ templates/ sprint- index.pt 2009-09-18 15:58:21 +0000
has_ any_specs view/has_ any_specificati ons">
--- lib/lp/
+++ lib/lp/
@@ -22,8 +22,6 @@
<div class=" top-portlet" > "context/ summary" >
- <h2>Meeting overview</h2>
-
<p>
<span tal:replace=
Sprint Summary Goes Here