Code review comment for lp:~mkanat/loggerhead/synchronize-lru_cache
Revision history for this message
| John A Meinel (jameinel) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Matt Nordhoff wrote:
> You have been requested to review the proposed merge of lp:~mkanat/loggerhead/synchronize-lru_cache into lp:loggerhead.
>
> Fixes Bug #420738 by synchronizing all our access to lru_cache, which is not thread-safe.
>
> In testing, I don't see any significant performance degradation under access from many different users accessing several different branches.
>
>
Seems fine to me. Note that the bzr-history-db stuff would supersede
this work.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkv
7YYAnAha0bJjXEr
=B/h8
-----END PGP SIGNATURE-----