Code review comment for lp:~mnordhoff/loggerhead/statictuples

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

John A Meinel wrote:
> Matt Nordhoff wrote:
>> Matt Nordhoff wrote:
>>> I wonder how much of an impact interning the stringified revnos would
>>> have? They're tiny, but they add up, and most of them are duplicates...
>> Although interning them when they're unmarshalled will lead to one ugly
>> list comprehension...
>
> as_st(x).intern()
>
> isn't all that bad.
>
> st(as_st(x[0]).intern(), as_st(x[1]).intern(),
> as_st(x[2]).intern()).intern()
>
> Isn't great, but it isn't terrible, either.
>
> John
> =:->

Yeah, but interning the individual items in the tuples would be.
--

« Back to merge proposal