Merge lp:~mterry/indicator-appmenu/one-too-many-refs into lp:indicator-appmenu/0.3
Proposed by
Michael Terry
Status: | Merged |
---|---|
Merged at revision: | 130 |
Proposed branch: | lp:~mterry/indicator-appmenu/one-too-many-refs |
Merge into: | lp:indicator-appmenu/0.3 |
Diff against target: |
37 lines (+4/-4) 2 files modified
src/Makefile.am (+2/-2) src/window-menus.c (+2/-2) |
To merge this branch: | bzr merge lp:~mterry/indicator-appmenu/one-too-many-refs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Indicator Applet Developers | Pending | ||
Review via email: mp+76809@code.launchpad.net |
Description of the change
In the course of tracking down the memory in bug 835646, I found this leak. It fixes part of the problem, but seemingly not all of it.
The problem here is that a ref is made before a call, thinking the call will unref it. But it doesn't. The call does a ref/unref pair.
(it's slightly more complicated than that. the call thinks that by disconnecting a signal, it will unref a ref that it expects to be made by the outer function (thus, reffing once and unreffing twice) -- but this particular code path doesn't do that, so the outer function ref isn't needed)
To post a comment you must log in.
(and I threw in a Makefile.am fix for free)