Code review comment for lp:~mterry/ubiquity/oem-config-merge

On Wed, Jul 08, 2009 at 12:57:06PM -0000, Michael Terry wrote:
> > * UBIQUITY_OEM_USER_CONFIG is a bit verbose as an environment variable name
> > (and "OEM user config" isn't a phrase I've ever used in connection with oem-
> > config, personally). How about just UBIQUITY_OEM?
>
> So, Ubiquity already had the idea of running in 'oem-config' mode,
> except just the first part of it (when the OEM is installing the OS
> and customizing). So I wanted a name that didn't conceptually
> conflict with the variable already used in that mode
> (self.oem_config). I figured 'the user configuration portion of an
> OEM install' somewhat naturally mapped to OEM_USER_CONFIG. I fear
> UBIQUITY_OEM would be confused with the first portion of an OEM
> install.

Oh, I see what you mean. In that case I think it's OK - we can always
change it later if need be since as you say it's internal.