Code review comment for lp:~mterry/ubiquity/oem-config-merge

Revision history for this message
Michael Terry (mterry) wrote :

> OK, branch updated with your suggested fixes. I also added a fix for the
> --query option printing to the debug log and fixed man page installation.

A couple comments about those fixes, actually. As for restricting netcfg and tasks, I changed the template to not offer those in the ubiquity case. And I changed base.py to warn and ignore any items in the list that weren't in the template's approved list.

But several times in your comments, you gave me the impression that you thought that the debconf frontend still worked in oem-config mode. That's not the case. I couldn't quite get it to work in either case. Just so we're on the same page about that. As long as that isn't a big deal regression for you, that's cool.

« Back to merge proposal