Code review comment for lp:~mterry/ubiquity/oem-config-merge

Revision history for this message
Evan (ev) wrote :

One last change and then I think this is good to go. If the introduction page is displayed, a fake page is inserted for bookkeeping, but pageslen is not incremented. This leads to the installer skipping the summary page and going straight into the install routine.

I've written a tiny patch for this here:
http://pastebin.ubuntu.com/217745/

I've tested your branch plus this patch with both regular ubiquity and in OEM mode and both look great. Booting into oem-config does not work, but further testing shows that it's a problem in trunk as well or with the daily-live CD I'm using. I've tested oem-config from the live CD desktop though, and it works just fine.

I'm going to vote Approve with the expectation that the above patch will be applied.

Colin, any further thoughts before we merge this?

review: Approve

« Back to merge proposal