Code review comment for lp:~mterry/ubiquity/plugins
Revision history for this message
| Colin Watson (cjwatson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On Tue, Sep 01, 2009 at 01:58:08PM -0000, Michael Terry wrote:
> Colin Watson wrote:
> > There are some delicate dependencies in scripts/install.py which I'm not
> > entirely sure you've preserved. The main one that comes to mind is that
> > configure_timezone (scripts/
> > syncing. I don't think configure_network has delicate dependencies of its own
> > so you can probably just run it earlier.
>
> Good point. Plugins should probably go near the end, since nothing
> can really depend on them anyway.
configure_locales, at least, probably needs to run early.
> I think I probably like namespacing non-API members the best and
> getting rid of get_ui(), as you suggest. Then official
> recommendations to plugin writers would be that all convenience
> members should start with an underscore.
This sounds sensible to me.