Code review comment for lp:~mterry/ubiquity/plugins

Revision history for this message
Michael Terry (mterry) wrote :

> configure_locales, at least, probably needs to run early.

I just moved network and apt ahead of plugins. Within the plugins, they are configured in the same order they are presented (which isn't necessarily a hard and fast rule -- if we had some page that needed a different ordering, it could be broken into two plugins, one for the UI-side and one for the install-side).

> > I think I probably like namespacing non-API members the best and
> > getting rid of get_ui(), as you suggest. Then official
> > recommendations to plugin writers would be that all convenience
> > members should start with an underscore.
>
> This sounds sensible to me.

OK, your suggested changes and the namespacing are now in my branch. But as we briefly discussed on IRC, this isn't urgent and is too risky for Alpha 5. But after A5, here's hoping!

review: Needs Resubmitting

« Back to merge proposal