Code review comment for lp:~mvo/launchpad/support-timeframe-fix-660433

Revision history for this message
Martin Pool (mbp) wrote :

On 21 October 2010 15:28, Jeroen T. Vermeulen <email address hidden> wrote:
> Martin, you make a good point.  I was actually just trying to be helpful: since I'm "proof-reading" the entire diff anyway, there's no need for Michael to go over the whole thing to find each individual instance that needs changing.  I just noted them consistently, as is common practice in Launchpad reviews.
>
> I'm used to this practice and don't feel in any way accused when a reviewer does it for me (or accusatory when I do it for someone else).  But now that you mention it, I suppose it does need an explanation for new contributors.

I don't take it as accusatory at all. There are probably some things
we could do in lp reviews to help with this - it would be neat if your
editor could jump through a list of review comments with the lines
they correspond to, or perhaps if a reviewer could more easily get in
and edit the branch...

--
Martin

« Back to merge proposal