Code review comment for lp:~mvo/launchpad/support-timeframe-fix-660433

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Argh! The test gets stuck when I run it:

Running germinate... ........................ done.
Running maintenance-check for hardy... done
Running maintenance-check for jaunty... done
Running maintenance-check for karmic... done
Running maintenance-check for lucid...

At that point maintenance-check.py sits effectively idle forever.

What I suspect happens is that the script tries to access the URLs that it has hard-coded into it:

{{{
# germinate output base directory
BASE_URL = "http://people.canonical.com/~ubuntu-archive/germinate-output/"

# hints dir url, hints file is "$distro.hints" by default
# (e.g. lucid.hints)
HINTS_DIR_URL = "http://people.canonical.com/~ubuntu-archive/seeds/platform.%s/SUPPORTED_HINTS"

# we need the archive root to parse the Sources file to support
# by-source hints
ARCHIVE_ROOT = "http://archive.ubuntu.com/ubuntu"
}}}

The test suite should not make any network connections outside of the test system. I'm afraid that to get this working, we may have to inject test doubles for these URLs as well.

(Also, on a very minor note, the current branch still adds cronscripts/publishing/tests although of course it's now empty.)

« Back to merge proposal