Code review comment for lp:~mwhudson/launchpad-cscvs/merge-creates-file-bug-120977-attempt-2
Revision history for this message
| Robert Collins (lifeless) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
The core change looks plausible to me. != None is a bad idea anyhow. /me looks at himself.
I'd write the acceptance tests in python, myself. They are more managable and introspectable. I long ago (4 years? maybe more?) stopped adding shell tests.