Code review comment for lp:~mwhudson/launchpad/back-off-failing-imports-bug-413637

Revision history for this message
Tim Penhey (thumper) wrote :

> def newJob(code_import, interval=datetime.timedelta(0)):

Shouldn't we default the interval to None? Having objects as default args just makes me feel funny.
Actually you do use interval=None in the model class. Can you update the interface to match please?

review: Approve

« Back to merge proposal