Code review comment for lp:~mwhudson/launchpad/bzr.dev-help

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Tim Penhey wrote:
> Review: Approve
> I'm happy with the changes, just one question:
>
> return os.path.join(
> os.path.dirname(os.path.dirname(bzrlib.__file__)),
> 'bzr')
>
> Have you checked that this actually gets the bzr from the bzr branch?

Good question! Surprisingly though, it doesn't actually matter: we
don't actually ever run this command directly (at least, that I can
find), we always run "./bin/py <path-to-bzr> <args>".

I think the answer is yes, in any case.

Cheers,
mwh

« Back to merge proposal