This branch makes the code import worker code much more careful about the formats that it might open. It's not a real problem so far because we only accept git:// urls for git imports, but for bzr-svn and for git over http, it will be.
Most of the changes by diff-volume are to do with how the tests are parameterized, the actual change is fairly simple.
It's a shame that only the LocalGitBzrDirFormat format is exercised in the tests whereas only the RemoteGitBzrDirFormat will be used in production. Not sure what we can do about that though.
Hi,
This branch makes the code import worker code much more careful about the formats that it might open. It's not a real problem so far because we only accept git:// urls for git imports, but for bzr-svn and for git over http, it will be.
Most of the changes by diff-volume are to do with how the tests are parameterized, the actual change is fairly simple.
It's a shame that only the LocalGitBzrDirF ormat format is exercised in the tests whereas only the RemoteGitBzrDir Format will be used in production. Not sure what we can do about that though.
Cheers,
mwh