Code review comment for lp:~mwhudson/launchpad/more-task-scheduled-bug-408638
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
EPIGRAMS IN PROGRAMMING:
58. Fools ignore complexity. Pragmatists suffer it. Some can avoid it. Geniuses remove it.
I hope I'm being a pragmatist here.
Hi Jono,
I hope you can make time to have a look at the branch some time today. If you don't have time for a full review, I'll get Tim to look at it tomorrow. But you already know what a DeferredLock is :)
If the code and tests don't make sense, then I've failed in my mission, but there are two issues addressed here:
1) Some race conditions around the puller exiting while a request for a job is pending (basically, change ITaskSource.stop to return deferred)
2) Addressing the behaviour where only one job gets pulled per run of the puller (see bug 408638)
Cheers,
mwh