Code review comment for lp:~mwhudson/launchpad/no-hosted-area-fix-useBzrBranch-users

Revision history for this message
Tim Penhey (thumper) wrote :

I know that it is not worth it now, but in
lib/lp/code/model/tests/test_branchjob.py you could
have just overridden the inherited useBzrBranches method
to make it always specify direct_database=True.

It may be an interesting count, but which is used more?
direct_database=True or False?

lib/lp/testing/__init__.py
 - you still have: raise AssertionError("XXX")

removeSecurityProxy(branch).last_scanned_id = 'null:'
 - is there a bzrlib constant we can use here?

And yes, it was a pretty boring branch to review. Great
to see a consistent use of getInternalBzrUrl and getBzrBranch.

review: Approve (conditional)

« Back to merge proposal