Code review comment for lp:~mwhudson/launchpad/permit_timeout_from_features-on-participation-bug-861510

Revision history for this message
Robert Collins (lifeless) wrote :

Re "The permit_timeout_from_features flag may have been conceived to help in
checking the timeout feature flag, but it seems to me that it applies to
all feature flags. Perhaps its name should be
"permit_feature_flag_lookup" and the feature flag code should raise an
exception if asked for a flag before the time is right."

No - its truely just the bootstrap mechanism for the db timeout
feature - there is -no- intent that other feature lookups, if they
happen before the db timeout is found, should be blocked (and it would
be a bad, surprising, bug to block them).

-Rob

« Back to merge proposal