Launchpad itself

Code review comment for lp:~mwhudson/launchpad/recipe-db-schema

  1. recipe-db-schema
  2. Merge into db-devel
Revision history for this message
Jonathan Lange (jml) wrote :

 * 'name' on SPRInstruction should be NOT NULL, I think.
 * You _could_ add a constraint saying that the line number should be strictly greater than the parent's line number. Not sure if this is necessary.
 * Shouldn't SourcePackageBuild.recipe be NOT NULL?

Other than that, looks good.

review: Needs Fixing

« Back to merge proposal