Code review comment for lp:~mwhudson/launchpad/test_traverse-set-participation-bug-611570

Revision history for this message
Gary Poster (gary) wrote :

Very nice, thank you.

FWIW, yes, browser:page was disparaged and eliminated from use at my last job (ZC), because of the dynamic class creation. (The newer approach is to subclass from zope.publisher.browser.BrowserPage, define your own __call__, and simply register the resulting class as an adapter.) That's what I/we didn't like about it, anyway.

review: Approve

« Back to merge proposal