Code review comment for lp:~mwhudson/loggerhead/relative-links

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

Poking around with this patch, it works, AFAICT.

I don't know enough about Loggerhead/Paste's URL handling to review it, though.

However, there is one problem, the feeds:

* <id> needs to be changed back to use absolute URLs.

* The Feed Validator also recommends using absolute URLs for <link rel="self" href="..." /> for maximum interoperability.

* The rest of the feeds can stick with relative URLs.

Once that's fixed, if you're sure nothing else needs to be changed, I have no objections to landing this. But as I said, I don't think I have the expertise to know if I should have any objections. :P

review: Needs Fixing

« Back to merge proposal