Code review comment for lp:~nhandler/launchpad/bugfix296469

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Unfortunately, the wording from the schema field is present on two forms: the request a review form, where the current wording is inappropriate and the form for performing a review, where the wording in this branch is inappropriate.

I think the fix is to consider all the browser interfaces that reference review_type (such as lp.code.browser.branch.RegisterProposalSchema, lp.code.browser.codereviewcomment.IEditCodeReviewComment...) and adjust the call to copy_field to override description to something sensible for that form.

As a general rule, we need to do this *way* more in Launchpad than we currently do, but this is a good place to start...

review: Needs Fixing

« Back to merge proposal