Code review comment for lp:~oubiwann/txaws/486365-get-bucket

Revision history for this message
Robert Collins (lifeless) wrote :

I've reviewed what I see on this web page: https://code.edge.launchpad.net/~oubiwann/txaws/486365-get-bucket/+merge/15343

I don't know if that is the whole branch or just an incremental bit; I think it might be the lot.

2024 +author = "txAWS Deelopers"

There is a bunch of duplication in the example scripts. I'd like to see that removed. Perhaps:
 - give them a if __name__ == guard
 - move the error/return etc callback support into script.py

Lastly, the default options in util/script.py include a bucket - is that relevant for all aws services? If not, lets factor that into two layers - truely global options and options for a given service.
e.g
 options = all_options()
 s3_options(options)

review: Approve

« Back to merge proposal