Code review comment for lp:~parthm/bzr/138600-2.1-mkdir-should-fail-on-invalid-parent

Revision history for this message
Andrew Bennetts (spiv) wrote :

Looks good to me, just like the original :)

It's a low risk change, so seems reasonable for 2.1. On that basis, it's probably just as appropriate for 2.0 too.

One trivial point: to reduce unnecessary conflicts, NEWS entries are supposed to be in alphabetical order, and in practice we have been ignoring punctuation and case when doing that sorting. So "``bzr" would sort before "Merge", not after. It doesn't matter very much.

review: Approve

« Back to merge proposal