Code review comment for lp:~parthm/bzr/262450
Revision history for this message
| Parth Malwankar (parthm) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Based on Martins comments:
>So probably the permissions stuff just can't work like this on Windows, in which case we should probably:
> 1- make that test requireFeature something unixy; probably it would be good to declare a new Feature for unix permissions and just say it exists if os.platform=posix
Added PosixOSFeature and the permissions test case now requireFeatures this.
> 2- check the actual runtime code passes on windows (even if it does nothing)
Ran tests on Window. It would be good if someone could verify this again.
> 3- file a followon bug about inheriting acls on windows
Filed bug #523187 for Windows