Code review comment for lp:~parthm/bzr/300062-better-handling-for-invalid-ignore-pattern

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Why do they need to catch it? Why can't the exception __str__ just
> show it, avoiding all changes to add/ignore/ignored and status
> commands?
>
> -Rob

Just mentioning that I don't think falling over and failing on an error
is the best route. When people want to run "bzr status" they want it to
complete. Completely blocking the user because they have a typo in their
ignore file is not going to win "user-friendly" points.

Obviously Robert and I disagree here, though, so we may need someone
else to chime in as a tiebreaker.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwFHfQACgkQJdeBCYSNAAM68QCgkT7TycEQ5NeRcs1rXgfRklrl
Bq8AoKfmmTzMfK+IbGrwaQ41kEuJWWvf
=n8/E
-----END PGP SIGNATURE-----

« Back to merge proposal