Code review comment for lp:~parthm/bzr/300062-better-handling-for-invalid-ignore-pattern

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
> > Why do they need to catch it? Why can't the exception __str__ just
> > show it, avoiding all changes to add/ignore/ignored and status
> > commands?
> >
> > -Rob
>
> Just mentioning that I don't think falling over and failing on an error
> is the best route. When people want to run "bzr status" they want it to
> complete. Completely blocking the user because they have a typo in their
> ignore file is not going to win "user-friendly" points.
>

Having `status` work seems reasonable to me because in case of failed
ignores the files displayed end up as 'unknown' and the rest of the
status should be the same. The code does get a little ugly as we need
to catch the exception in three places in status.py.