Code review comment for lp:~parthm/bzr/300062-better-handling-for-invalid-ignore-pattern

On 2 June 2010 00:52, John A Meinel <email address hidden> wrote:
> Just mentioning that I don't think falling over and failing on an error
> is the best route. When people want to run "bzr status" they want it to
> complete. Completely blocking the user because they have a typo in their
> ignore file is not going to win "user-friendly" points.

I would tend to expect it to give a user warning not an error. If
it's unreasonably messy or slow to implement I wouldn't absolutely
insist on it. A user friendly error is an improvement on an internal
error.

--
Martin <http://launchpad.net/~mbp/>